This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Improve debug info for partial inlining (PR debug/54519)

On Tue, Sep 11, 2012 at 04:41:24PM +0200, Steven Bosscher wrote:
> > +  if (args_to_skip)
> > +    for (parm = DECL_ARGUMENTS (current_function_decl), num = 0;
> > +        parm; parm = DECL_CHAIN (parm), num++)
> > +      if (bitmap_bit_p (args_to_skip, num)
> > +         && is_gimple_reg (parm))
> > +       {
> > +         tree ddecl;
> > +         gimple def_temp;
> > +
> > +         arg = get_or_create_ssa_default_def (cfun, parm);
> > +         if (!MAY_HAVE_DEBUG_STMTS)
> > +           continue;
> 
> You can do this MAY_HAVE_DEBUG_STMTS check before the loop, e.g.
> 
> > +  if (args_to_skip && MAY_HAVE_DEBUG_STMTS)

No, that would result in -fcompare-debug failures if parm doesn't have a
default def yet.

	Jakub
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]