This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Combine location with block using block_locations

From: Diego Novillo <dnovillo at google dot com>
To: Richard Guenther <richard dot guenther at gmail dot com>
Cc: Dehao Chen <dehao at google dot com>, Dodji Seketeli <dodji at redhat dot com>, gcc-patches at gcc dot gnu dot org, Jakub Jelinek <jakub at redhat dot com>, Jan Hubicka <hubicka at ucw dot cz>, David Li <davidxl at google dot com>, Tom Tromey <tromey at redhat dot com>, Jason Merrill <jason at redhat dot com>, Richard Henderson <rth at redhat dot com>
Date: Fri, 07 Sep 2012 07:08:29 -0400
Subject: Re: [PATCH] Combine location with block using block_locations
References: <CAO2gOZXFkCpuFqXpPw6ju14BB=RBdt-kDhKsJgk4N41=Q19VHw@mail.gmail.com> <CAFiYyc2Grzseuxh6+twWKRsuLhxie5R9h8WPEfsKEoe5Hfmwaw@mail.gmail.com> <CAO2gOZXHVkaW41KN3E4viQEe2bn4bP_LLt-VbmBB3zboPyU_sg@mail.gmail.com> <CAFiYyc0KmntyrbOReSCjLLL0Z-OeYn=6dZZ2AmV7JPgtEV6UbQ@mail.gmail.com> <CAO2gOZXDVyfu15Y=QL74Lq+CP-fJXXdhR=53+sU5-KyN2haDqg@mail.gmail.com> <CAFiYyc02+Ahg-RC5JjJtBDeQPMmUXruaY6yKAi8yz_6ftagHgw@mail.gmail.com> <CAO2gOZV6nHjTiTEtrt64r_Hc5_CGZTqYGMRDXwWULdO5AX43Jg@mail.gmail.com> <m3has6od2w.fsf@redhat.com> <CAO2gOZWbCiFH0TJxxAfzqpZyuE=kRsrtCc0k+WjAoYaafhkSUA@mail.gmail.com> <m3y5lhnbzi.fsf@redhat.com> <CAO2gOZVFTNraCNOS4J1dV9T7XyFY=QHbhZ_i3Jx9yY6EM5+46w@mail.gmail.com> <CAO2gOZWsX_SP+zZX5t_xnXUUVSCz0WpRQy=oJumKY3_mDCXGSA@mail.gmail.com> <CAFiYyc0X7kGj95SvQfBpDxY=UMvyDXCCALwFTXXn+4oYJ8x04g@mail.gmail.com> <CAO2gOZWG_Gw3MejvA58M1GrXj=7s6fkURX3NmGT=cUgMwHz=RQ@mail.gmail.com> <CAFiYyc0c3ZyLkbTGiiOOi0sCC0Ju9=PQLZ-BAOV2RFYVttzvCA@mail.gmail.com>

On 2012-09-06 05:46 , Richard Guenther wrote:

On Wed, Aug 22, 2012 at 1:54 AM, Dehao Chen <dehao@google.com> wrote:

On Tue, Aug 21, 2012 at 6:25 AM, Richard Guenther
<richard.guenther@gmail.com> wrote:

On Mon, Aug 20, 2012 at 3:18 AM, Dehao Chen <dehao@google.com> wrote:
ping....
Conceptually I like the change.  Can a libcpp maintainer please have a 2nd
look?
Dehao, did you do any compile-time and memory-usage benchmarks?


I don't have a memory benchmarks at hand. But I've tested it through
some huge apps, each of which takes more than 1 hour to build on a
modern machine. None of them had observed noticeable memory footprint
and compile time increase.

Thanks.

I'd like to see a 2nd "ok", but hereby I give a first one ;)  It's a big change
but definitely a good one.

Dehao, could you attach a final, and complete, patch? I've seen 3 or 4 patches in this thread. The latest version is only a fragment of the full patch.

Thanks. Diego.

Follow-Ups:
- Re: [PATCH] Combine location with block using block_locations
  - From: Dehao Chen

References:
- Re: [PATCH] Combine location with block using block_locations
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]