This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, ARM] Constant vector permute for the Neon vext insn

From: Christophe Lyon <christophe dot lyon at linaro dot org>
To: Richard Henderson <rth at redhat dot com>
Cc: Richard Earnshaw <rearnsha at arm dot com>, gcc-patches at gcc dot gnu dot org
Date: Mon, 3 Sep 2012 10:59:48 +0200
Subject: Re: [PATCH, ARM] Constant vector permute for the Neon vext insn
References: <CAKdteOb98RYsXwJKjpAcPH=7JppTg=xSes4yRRfpeUx085d1Hg@mail.gmail.com> <50373DE0.8010208@arm.com> <CAKdteOaSEk_pREPcvYbGZDRCezSEGnRxcuCgMyhkefbpCfp9sw@mail.gmail.com> <CAKdteOaoxHMruRRhA57eLzkyYkN_KHfbKo3-7MfLZL8P_NmCRw@mail.gmail.com> <CAKdteOaz-8HNcRb9W8qO5MtVx6akLS3QFQEmQFYut9bWc5Zi2Q@mail.gmail.com> <5040DF68.2020608@redhat.com>

On 31 August 2012 17:59, Richard Henderson <rth@redhat.com> wrote:
> On 2012-08-31 07:25, Christophe Lyon wrote:
>> +  offset = gen_rtx_CONST_INT (VOIDmode, location);
>
> Never call gen_rtx_CONST_INT directly.  Use GEN_INT.
>
>
Here is an updated patch with that small change.
For the record, there are quite a few existing calls to
gen_rtx_CONST_INT, maybe a cleanup pass is needed?

Thanks,

Christophe.

2012-09-03  Christophe Lyon  <christophe.lyon@linaro.org>

	gcc/
	* config/arm/arm.c (arm_evpc_neon_vext): New
	function.
	(arm_expand_vec_perm_const_1): Add call to
	arm_evpc_neon_vext.


	gcc/testsuite/
	* gcc.target/arm/neon-vext.c
	gcc.target/arm/neon-vext-execute.c:
	New tests.

Attachment: gcc-vec-permute-vext.patch
Description: Binary data

Follow-Ups:
- Re: [PATCH, ARM] Constant vector permute for the Neon vext insn
  - From: Ramana Radhakrishnan

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]