This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix double_int overflow in VRP PLUS_EXPR


On Wed, Aug 22, 2012 at 02:34:01PM +0200, Marc Glisse wrote:
> On Wed, 22 Aug 2012, Jakub Jelinek wrote:
> 
> >>>2012-08-21  Marc Glisse  <marc.glisse@inria.fr>
> >>>+  n <<= (8 * sizeof (NT) - 1);
> >
> >Better use __CHAR_BIT__ instead of 8 here...
> 
> Ok, I committed the __CHAR_BIT__ version (I just compiled that one
> file manually with old and new compilers, I didn't restart the
> testsuite, I hope the manual test is enough to detect any typo that
> could break things).

Probably.  You could have used:
make check-gcc RUNTESTFLAGS=tree-ssa.exp=vrp79.c
to test just that single testcase (with both old and new compilers).

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]