This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [Patch ARM] Update the test case to differ movs and lsrs for ARM mode and non-ARM mode
- From: "Terry Guo" <terry dot guo at arm dot com>
- To: "Richard Earnshaw" <Richard dot Earnshaw at arm dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 22 Aug 2012 19:16:14 +0800
- Subject: RE: [Patch ARM] Update the test case to differ movs and lsrs for ARM mode and non-ARM mode
- References: <000001cd8004$485ab0e0$d91012a0$@guo@arm.com> <5034AF05.2090905@arm.com>
> >
> > Due to the impact of ARM UAL, the Thumb1 and Thumb2 mode use LSRS
> > instruction while the ARM mode uses MOVS instruction. So the
> following case
> > is updated accordingly. Is it OK to trunk?
> >
> > BR,
> > Terry
> >
> > 2012-08-21 Terry Guo <terry.guo@arm.com>
> >
> > * gcc.target/arm/combine-movs.c: Check movs for ARM mode
> > and lsrs for other mode.
> >
>
> This can't be right. Thumb1 doesn't use unified syntax.
>
> R.
>
oops. You are right. Sorry for making such obvious mistake.
Here is patch updated to distinguish ARM and Thumb2.
Tested for Thumb1, Thumb2 and ARM modes. No regression.
Is it OK?
BR,
Terry
2012-08-21 Terry Guo <terry.guo@arm.com>
* gcc.target/arm/combine-movs.c: Check movs for ARM mode
and lsrs for Thumb2 mode.
diff --git a/gcc/testsuite/gcc.target/arm/combine-movs.c
b/gcc/testsuite/gcc.target/arm/combine-movs.c
index 4209a33..3e36033 100644
--- a/gcc/testsuite/gcc.target/arm/combine-movs.c
+++ b/gcc/testsuite/gcc.target/arm/combine-movs.c
@@ -9,4 +9,5 @@ void foo (unsigned long r[], unsigned int d)
r[i] = 0;
}
-/* { dg-final { scan-assembler "movs\tr\[0-9\]" } } */
+/* { dg-final { scan-assembler "lsrs\tr\[0-9\]" { target arm_thumb2_ok } }
} */
+/* { dg-final { scan-assembler "movs\tr\[0-9\]" { target { ! arm_thumb2_ok
} } } } */