Re: Speedups/Cleanups: End of GSOC patch collection

[Dimitrios Apostolou <jimis at gmx dot net>]

2012-08-18 Dimitrios Apostolou <jimis@gmx.net>

	* dwarf2out.c (output_indirect_string): Use
	ASM_OUTPUT_INTERNAL_LABEL instead of slower ASM_OUTPUT_LABEL.
	* varasm.c (assemble_string): Don't break string in chunks, this
	is assembler specific and already done in most versions of
	ASM_OUTPUT_ASCII.


I think there is no correctness issue regarding output_indirect_string()
since .debug_str are always compiler generated labels, and this gives a 
small speedup with -g3 debug info.

And regarding assemble_string() I find it superfluous to break it in two
places. I found only the following versions of ASM_OUTPUT_ASCII not caring 
about string length, I guess the assemblers don't have a limit:

arm.c: vmsdbgout.c:ASM_OUTPUT_ASCII
picochip.c: picochip_output_ascii()
pdp11.c: output_ascii()


Thanks,
Dimitris

Attachment: varasm-assemble_string.diff
Description: Text document

Attachment: dwarf2out-indirect_string.diff
Description: Text document