This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: PR target/20020: 128 bit structs not targeted to TImode
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Gary Funck <gary at intrepid dot com>, Richard Henderson <rth at redhat dot com>, jh at suse dot cz
- Date: Fri, 17 Aug 2012 21:35:01 +0200
- Subject: Re: PATCH: PR target/20020: 128 bit structs not targeted to TImode
- References: <20120816174145.GA7290@intel.com>
On Thu, Aug 16, 2012 at 7:41 PM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> My email sent to gcc-patches@gcc.gnu.org was bounced as spam. I am
> resending it. This patch defines both MAX_FIXED_MODE_SIZE and
> MEMBER_TYPE_FORCES_BLK for i386. MEMBER_TYPE_FORCES_BLK is needed so
> that we always put union with XFmode field in BLKmode. This patch
> doesn't change any ABI since both MAX_FIXED_MODE_SIZE and
> MEMBER_TYPE_FORCES_BLK aren't ABI macros. They only change code
> quality. Tested on Linux/x86-64. OK to install?
> gcc/
>
> 2012-08-16 H.J. Lu <hongjiu.lu@intel.com>
> Gary Funck <gary@intrepid.com>
>
> PR target/20020
> * config/i386/i386.h (MAX_FIXED_MODE_SIZE): New macro.
> (MEMBER_TYPE_FORCES_BLK): Likewise.
>
> gcc/testsuite/
>
> 2012-08-16 H.J. Lu <hongjiu.lu@intel.com>
> Gary Funck <gary@intrepid.com>
>
> PR target/20020
> * gcc.target/i386/pr20020-1.c: New test.
> * gcc.target/i386/pr20020-2.c: Likewise.
> * gcc.target/i386/pr20020-3.c: Likewise.
OK, but please check for possible xmm vs. integer reg pair code
regressions and similar for mm vs. int reg pair on 32bit targets.
Thanks,
Uros.