This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Commit: RL78: Include tree-pass.h
On Wed, Aug 8, 2012 at 3:35 PM, Ian Lance Taylor <iant@google.com> wrote:
> On Wed, Aug 8, 2012 at 1:45 AM, Richard Guenther
> <richard.guenther@gmail.com> wrote:
>> On Wed, Aug 8, 2012 at 10:28 AM, Nick Clifton <nickc@redhat.com> wrote:
>>> Hi DJ,
>>>
>>> I am applying the following patch to the gcc mainline as an obvious
>>> fix for the following problem building the RL78 backend:
>>>
>>> gcc/config/rl78/rl78.c:151:3: error: 'PASS_POS_INSERT_BEFORE' undeclared here (not in a function)
>>
>> Err - you are inside the compiler and should not use plugin stuff to
>> register your machine dependent pass.
>
> But we should definitely have a way to register machine dependent
> passes, and what's wrong with the plugin interface?
I don't think we really want that (machine dependent passes). It seems
we cannot get away with it (so we have mdreorg). Allowing (some) flexibility
where to put mdreorg is ok, using two different mechanisms (mdreorg and
a "plugin") sounds odd and is IMHO bad for consistency.
Richard.
> Ian