This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, libiberty] avoid closing files twice on Windows when exec fails
- From: DJ Delorie <dj at redhat dot com>
- To: Sandra Loosemore <sandra at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, kazu at codesourcery dot com
- Date: Thu, 26 Jul 2012 18:53:02 -0400
- Subject: Re: [patch, libiberty] avoid closing files twice on Windows when exec fails
- References: <5011C109.9090503@codesourcery.com>
I wonder if registering a handler for invalid parameters, at least
around those calls, so that we can enforce the posix-like "return an
error" semantics?
> OK for mainline?
Ok.
> 2012-07-26 Kazu Hirata <kazu@codesourcery.com>
> Sandra Loosemore <sandra@codesourcery.com>
>
> libiberty/
> * pex-win32.c (pex_win32_exec_child): Only close original file
> descriptors if child is launched successfully.