This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RESEND-2][PATCH] Allow printing of escaped curly braces in assembler directives with operands
On Fri, 20 Jul 2012 22:24:57 -0400 (EDT), Hans-Peter wrote:
> Sounds like a good idea, but I think you shouldn't limit that to
> "{}" but rather introduce \ to escape and cause any next
> character to be emitted as-is, in particular "|".
I had dropped the change to escape "|" thinking it wasn't needed -- it
gets interpreted as a special character only if it is within a {}. It
makes sense to add it though, since there could be a use case to have
a '|' within the assembler dialect options.
> That's a target (yes, counting it as one target) that defines
> ASSEMBLER_DIALECT wherein "{}|" has the predefined meaning you
> try to escape. I suggest testing a non-ASSEMBLER_DIALECT target
> as well. And check that no target uses \\ for something else
> through ASM_FPRINTF_EXTENSIONS... ...so it seems like %{ etc.
> would be safer.
OK, I'll do this and post a modified patch. Thanks for the review!
Regards,
Siddhesh