This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 1/6] Thread pointer built-in functions, core parts
- From: Chung-Lin Tang <cltang at codesourcery dot com>
- To: gcc-patches <gcc-patches at gcc dot gnu dot org>, <rsandifo at nildram dot co dot uk>
- Date: Fri, 13 Jul 2012 14:52:25 +0800
- Subject: Re: [PATCH 1/6] Thread pointer built-in functions, core parts
- References: <4FFE741E.7080506@codesourcery.com> <87wr287rn6.fsf@talisman.home>
On 2012/7/13 02:37 AM, Richard Sandiford wrote:
>> +void
>> > +default_expand_builtin_set_thread_pointer (rtx val ATTRIBUTE_UNUSED)
>> > +{
>> > + sorry ("__builtin_set_thread_pointer() not available for this target");
>> > +}
> Function names should be quoted by %< %>. But maybe we can save the
> translators some work and use:
>
> sorry ("%qs is not available for this target", "__builtin_thread_pointer()");
> ...
> sorry ("%qs is not available for this target",
> "__builtin_set_thread_pointer()");
Seeing default_expand_builtin_saveregs() as a current example, using %qs
sort of diverges from the style, though I'm not sure if that should be
changed too...personally I think unquoted looks cleaner :)
Another small detail, should '()' be included with the function name in
the diagnostic message?
Thanks,
Chung-Lin