This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fwd: [Bug debug/53754] [4.8 Regression][lto] ICE in lhd_decl_printable_name, at langhooks.c:222 (with -g)
- From: Cary Coutant <ccoutant at google dot com>
- To: Richard Guenther <rguenther at suse dot de>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 29 Jun 2012 11:00:52 -0700
- Subject: Re: Fwd: [Bug debug/53754] [4.8 Regression][lto] ICE in lhd_decl_printable_name, at langhooks.c:222 (with -g)
- References: <bug-53754-19931@http.gcc.gnu.org/bugzilla/> <bug-53754-19931-FA9sV8OfRi@http.gcc.gnu.org/bugzilla/> <CAHACq4q0ed+dkEimrpQCdWQPp4GgD6z19XWRNo7JoRDBBA2UFg@mail.gmail.com> <CAHACq4q5U4qTwqL10qF0S39d_kc+_+_UymraBDn0JAufKHYFVA@mail.gmail.com> <alpine.LNX.2.00.1206291005520.17233@jbgna.fhfr.qr>
> > (What's the right way to send a patch to fix a PR? I'm not even sure
> > whether you were cc'ed on my response.)
>
> The right way to send a patch to fix a PR is to send it to gcc-patches ;)
Well, yeah, but in this case I was just proposing a patch for
discussion, and using the bugzilla mechanism didn't seem to be
working. I guess it's gcc-patches even for discussion.
> > > You can't delay producing pubnames this way with LTO. ?Please fix.
> >
> > The obvious problem is that we're calling langhooks.dwarf_name (in
> > gen_namespace_die) for an anonymous namespace, even with the default
> > -gno-pubnames. I can fix that by adding a check for want_pubnames just before
> > the call to add_pubname_string, as in the patch below. But this is still going
>
> That's sensible anyways - you avoid useless work. ?So the patch is ok.
OK, I'll submit this patch, but leave the PR open and follow up with
something to fix the underlying problem as you suggest.
-cary