This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC C++ / PR51033 ] Handle __builtin_shuffle in constexpr properly in the C++ frontend.


On 25 June 2012 04:32, Jason Merrill <jason@redhat.com> wrote:
> On 06/18/2012 09:04 AM, Ramana Radhakrishnan wrote:
>>
>> + ?location_t loc = EXPR_LOC_OR_HERE (t);
>
>
> We should only use EXPR_LOC_OR_HERE for diagnostics. ?For a location to use
> in building other expressions, use EXPR_LOCATION.

Thanks for the review. I've made that change and committed the following patch.

Ramana


>
> OK with that change.
>
> Jason
>

Attachment: committed.patch
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]