This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix ICE in expand_cse_reciprocals (PR tree-optimization/42078)
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: Richard Guenther <richard dot guenther at gmail dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 14 Jun 2012 03:20:38 -0300
- Subject: Re: [PATCH] Fix ICE in expand_cse_reciprocals (PR tree-optimization/42078)
- References: <20091118173010.GL3047@sunsite.ms.mff.cuni.cz> <ortywrgy8o.fsf@livre.localdomain> <orpr7fgrib.fsf@livre.localdomain> <84fc9c000911190615v65576f2ahd76a0f28b3f725ae@mail.gmail.com> <or7htledxb.fsf@livre.localdomain> <or39jrm1ju.fsf@livre.localdomain> <ork41pe7hk.fsf@livre.localdomain> <CAFiYyc0Ranxo3p06pOcjucVO-F9wwCSGNpFzmE_-=2-dLLXLOw@mail.gmail.com>
On Apr 12, 2012, Richard Guenther <richard.guenther@gmail.com> wrote:
> + /* If the conditions in which this function uses VALUE change,
> + adjust gimple_replace_lhs_wants_value(). */
> + gcc_assert (gimple_replace_lhs_wants_value ()
> + == MAY_HAVE_DEBUG_STMTS);
> +
if (MAY_HAVE_DEBUG_STMTS)
{
> that looks ... odd.
Indeed, it does. Does this look any better?
bool save_value = MAY_HAVE_DEBUG_STMTS;
/* If the condition above, in which this function uses VALUE change,
adjust gimple_replace_lhs_wants_value() to match. The assert
below helps enforce this. */
gcc_checking_assert (gimple_replace_lhs_wants_value () == save_value);
if (save_value)
{
--
Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/ FSF Latin America board member
Free Software Evangelist Red Hat Brazil Compiler Engineer