This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [testsuite] lib/dg-pch.exp: distinguish between two compilations in summary
- From: Janis Johnson <janis_johnson at mentor dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: <janisjo at codesourcery dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 13 Jun 2012 14:57:30 -0700
- Subject: Re: [testsuite] lib/dg-pch.exp: distinguish between two compilations in summary
- References: <4FD90309.1030108@mentor.com> <Pine.LNX.4.64.1206132136200.29380@digraph.polyomino.org.uk>
- Reply-to: <janisjo at codesourcery dot com>
On 06/13/2012 02:37 PM, Joseph S. Myers wrote:
> On Wed, 13 Jun 2012, Janis Johnson wrote:
>
>> PCH test infrastructure compiles each test twice, with identical results
>> in the test summary file (assuming they both pass or both fail). This
>> patch adds an extra flag to each compile, "-Dcompile1" or "-Dcompile2",
>> to make the summary lines unique. This is a rather lame fix but at
>> least I added a comment.
>
> I would have said this was bug 20771, except that you committed a fix for
> that in 2008, so either it's a reappearance or the reason you didn't close
> the bug in 2008 was that your fix was known incomplete. Anyway, check for
> open "testsuite" bugs for the issues you are fixing.
>
The patch for PR20771 did fix the problem (so I should have closed it)
but it was undone as part of a later change to the same lines. I could
either do that again, with comments this time explaining why they are
slightly different, or use "-Dwith_PCH" and "-Dwithout_PCH" in the flags
that will appear in the test summary. Do you have a preference?
Janis