This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Remove cfglayout.h, and distribute cfglayout.c code to users
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: Steven Bosscher <stevenb dot gcc at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 11 Jun 2012 11:02:40 +0200
- Subject: Re: [patch] Remove cfglayout.h, and distribute cfglayout.c code to users
- References: <CABu31nNw5Df0p-wJej01YGd6S=BdXkLxVb8LWkMPTRyxfT9NsA@mail.gmail.com>
On Thu, Jun 7, 2012 at 10:18 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> Hello,
>
> The attached patch removes cfglayout.h. It was included in a lot of
> places that didn't need it, and it didn't define much anyway.
>
> While checking the users of cfglayout.h, I noticed that a lot of code
> in cfglayout.c can be made local to users (reemit_insn_block_notes ->
> final.c) or doesn't have to do much with cfglayout mode per se (all
> insn locator code -> emit-rtl.c). This of course uncovered a buglet:
> function.h's x_last_location wasn't used, but emit-rtl.c had a define
> that interfered with the last_location for the insn locators.
>
> And it seemed rather strange that emit-rtl.c should include
> tree-flow.h, so I moved some non-GIMPLE tree-EH related function
> prototypes from tree-flow.h to tree.h (in retrospect, I should
> probably have made that a separate patch, but these patches tend to
> evolve, rather than be designed... ;-)
>
> Bootstrapped on x86_64-unknown-linux-gnu. OK?
Ok!
Thanks,
Richard.
> Ciao!
> Steven