This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][C++] Fix PR52841

On 06/06/2012 04:09 AM, Fabien Chêne wrote: 
Out of curiosity, do you happen to know what kind of problem was
triggered here ?
Shouldn't we fix the underlying issue as well ? Unless that the
canonical way to solve it be to simply return earlier...

Often if we continue parsing something on the assumption that the previous bits are correct it leads to problems; that's all there is to this bug. When we see

using sat::Solvable::bool_type;

cp_parser_alias_declaration eats "sat" and then tries to parse ::Solvable::bool_type as a type-id, which fails.

Returning when we hit a parse error is the right fix.

Jason

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]