This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: _FORTIFY_SOURCE for std::vector

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Florian Weimer <fweimer at redhat dot com>
Cc: libstdc++ at gcc dot gnu dot org, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 01 Jun 2012 15:19:24 +0200
Subject: Re: _FORTIFY_SOURCE for std::vector
References: <4FC8A0DE.7030104@redhat.com> <4FC8AA97.2010909@oracle.com> <4FC8BB52.7030600@redhat.com> <4FC8BEFF.1050007@oracle.com>

On 06/01/2012 03:09 PM, Paolo Carlini wrote:

You are right, sorry, I went through your changes too quickly and didn't realize that you are just using the existing _M_range_check. Anyway, I confirm that probably we want something more consistent with debug-mode, thus not throwing in this case. Maybe just a __builtin_abort(), I don't know. Or adjust the code in c++config to make available a non-trivial __glibcxx_assert also when _FORTIFY_SOURCE > 0.

Then, if you do this, you probably don't need a new _M_fortify_range_check function.

Paolo.

References:
- _FORTIFY_SOURCE for std::vector
  - From: Florian Weimer
- Re: _FORTIFY_SOURCE for std::vector
  - From: Paolo Carlini
- Re: _FORTIFY_SOURCE for std::vector
  - From: Florian Weimer
- Re: _FORTIFY_SOURCE for std::vector
  - From: Paolo Carlini

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]