This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/2] arm: add iwMMXt mmx-2.c test
- From: Matt Turner <mattst88 at gmail dot com>
- To: Ramana Radhakrishnan <ramana dot radhakrishnan at linaro dot org>
- Cc: gcc-patches at gcc dot gnu dot org, Nick Clifton <nickc at redhat dot com>, Richard Earnshaw <richard dot earnshaw at arm dot com>, Paul Brook <paul at codesourcery dot com>, Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>
- Date: Mon, 28 May 2012 17:55:00 -0400
- Subject: Re: [PATCH 2/2] arm: add iwMMXt mmx-2.c test
- References: <1333564533-26841-1-git-send-email-mattst88@gmail.com> <CACUk7=VoM=wtD9-NbWATFPYLOGDr5R_VcEsKxLqo1-cKRko2PA@mail.gmail.com>
On Thu, Apr 5, 2012 at 4:53 AM, Ramana Radhakrishnan
<ramana.radhakrishnan@linaro.org> wrote:
> On 4 April 2012 19:35, Matt Turner <mattst88@gmail.com> wrote:
>> ?gcc/testsuite/gcc.target/arm/mmx-2.c | ?158 ++++++++++++++++++++++++++++++++++
>> ?1 files changed, 158 insertions(+), 0 deletions(-)
>> ?create mode 100644 gcc/testsuite/gcc.target/arm/mmx-2.c
>>
>> diff --git a/gcc/testsuite/gcc.target/arm/mmx-2.c b/gcc/testsuite/gcc.target/arm/mmx-2.c
>> new file mode 100644
>> index 0000000..603a63b
>> --- /dev/null
>> +++ b/gcc/testsuite/gcc.target/arm/mmx-2.c
>> @@ -0,0 +1,158 @@
>> +/* { dg-do compile } */
>> +/* { dg-skip-if "Test is specific to the iWMMXt" { arm*-*-* } { "-mcpu=*" } { "-mcpu=iwmmxt" } } */
>> +/* { dg-skip-if "Test is specific to the iWMMXt" { arm*-*-* } { "-mabi=*" } { "-mabi=iwmmxt" } } */
>> +/* { dg-skip-if "Test is specific to the iWMMXt" { arm*-*-* } { "-march=*" } { "-march=iwmmxt" } } */
>> +/* { dg-skip-if "Test is specific to ARM mode" { arm*-*-* } { "-mthumb" } { "" } } */
>
> How about simplifying this with a dg-require-effective-target
> arm_arm_ok instead of doing
> dg-require-effective-target arm32 and then skipping it for Thumb2 ?
I might not understand properly, but couldn't I just do this?
/* { dg-require-effective-target arm_iwmmxt_ok } */
Thanks,
Matt