This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [cxx-conversion] New Hash Table (issue6244048)
On Fri, May 25, 2012 at 9:33 AM, Paolo Carlini <pcarlini@gmail.com> wrote:
> Hi,
>
>> On Fri, May 25, 2012 at 7:17 AM, Michael Matz <matz@suse.de> wrote:
>>> Hi,
>>>
>>> On Fri, 25 May 2012, Jakub Jelinek wrote:
>>>
>>>>> + ?/* Return the current size of this hash table. ?*/
>>>>> +
>>>>> + ?size_t size()
>>>>> + ?{
>>>>> + ? ?return htab->size;
>>>>> + ?}
>>>>
>>>> (and various other places) - formatting is wrong, missing space between (.
>>>
>>> And it doesn't start at the first column, and type isn't on a separate
>>> line.
>
> I don't think I'm going to follow this discussion in much detail and, more importantly, I don't know how representative may own contributions are as 'libstdc++ style', but I *always* have the return type on a separate line in my own patches. It's true however that we don't normally put a space between name and open round bracket, but hey, I don't think we (the libstdc++ people) are so in love with that: myself would approve right away a big mechanical patch adding spaces everywhere, to be clear.
>
no, you don't want to do that :-)
-- Gaby