This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Fix PR ada/52362
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: Paolo Bonzini <bonzini at gnu dot org>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 25 May 2012 09:08:45 +0200
- Subject: Re: [patch] Fix PR ada/52362
- References: <201205182305.39231.ebotcazou@adacore.com>
Paolo,
> The fix is mainly in the Ada tools, but there is a hitch: when you pass a
> response file to the linker by means of the -Wl,@ option, it is intercepted
> by collect2. And collect2 creates another response file for the linker
> proper only if HAVE_GNU_LD is set to 1. Now HAVE_GNU_LD is set to 1 only
> if you pass the --with-ld= or --with-gnu-ld switches at configure time; in
> particular, for systems where the use of the GNU linker is the only choice
> and thus hardcoded in config.gcc (e.g. Linux), you can end up with
> HAVE_GNU_LD set to 0, breaking the response file mechanism. Hence the
> configure.ac hunk.
>
> Tested on i586-suse-linux and i686-pc-mingw32, OK for mainline and 4.7
> branch?
>
>
> 2012-05-18 Eric Botcazou <ebotcazou@adacore.com>
>
> PR ada/52362
> * config.gcc (i[34567]86-*-mingw* | x86_64-*-mingw*): Set gas and
> gnu_ld variables to yes.
> * configure.ac (HAVE_GNU_LD): Move to after config.gcc inclusion.
> (HAVE_GNU_AS): Likewise.
> * config.in: Regenerate.
> * configure: Likewise.
What do you think about the above change? Thanks in advance.
--
Eric Botcazou