This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ Patch] PR 29185

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Jason Merrill <jason at redhat dot com>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Wed, 23 May 2012 12:53:10 +0200
Subject: Re: [C++ Patch] PR 29185
References: <4FBC3C7F.9070803@oracle.com> <4FBC68EC.9060801@redhat.com>

On 05/23/2012 06:34 AM, Jason Merrill wrote:

On 05/22/2012 09:25 PM, Paolo Carlini wrote:
some years ago Martin lamented that we weren't consistently warning
about deleting member arrays vs arrays.
I wonder why we look at the code of exp at all. Surely deleting any expression with array type is questionable.

Indeed. The below, as-is, bootstraps and tests fine.

I wondered whether adding a check that TREE_TYPE is non null could provide a tad of additional robustness, but noticed that the next build_expr_type_conversion just uses MAYBE_CLASS_TYPE_P on it.

Thanks!
Paolo.

/////////////////

Attachment: patch_29185_2
Description: Text document

Follow-Ups:
- Re: [C++ Patch] PR 29185
  - From: Jason Merrill

References:
- [C++ Patch] PR 29185
  - From: Paolo Carlini
- Re: [C++ Patch] PR 29185
  - From: Jason Merrill

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]