Re: [C++ Patch] PR 44516

[Paolo Carlini <paolo dot carlini at oracle dot com>]

On 05/22/2012 05:42 PM, Jason Merrill wrote:
> On 05/22/2012 08:22 AM, Paolo Carlini wrote:
> > Ok, thanks. Today I wanted to concretely test and post a patch but I
> > noticed this other objc bit in objc-next-runtime-abi-01.c which I don't
> > know how to handle due to the OPT_Wall gate:
> >
> > warning_at (UNKNOWN_LOCATION, OPT_Wall,
> > "%<-fobjc-sjlj-exceptions%> is the only supported exceptions "
> > "system for %<-fnext-runtime%> with %<-fobjc-abi-version%> < 2");
> >
> > If the objc maintainers could help with those uses of warning_at (0 in
> > the objc tree, I have a patch ready for the asserts proper.
>
> What if we just changed UNKNOWN_LOCATION to BUILTINS_LOCATION for 
> these diagnostics?
Maybe... I don't know really, what happens with that location. 
Alternately, I bootstrapped and I'm finishing testing the below. Let me 
know, I don't have a strong opinion at the moment: if we can 
consistently use inform for all those general messages provided by objc, 
I think it would be good, I don't know how "bad" is adding warn_all.

Thanks,
Paolo.

///////////////////////

Attachment: CL_diagnostic
Description: Text document

Attachment: patch_diagnostic
Description: Text document