This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Use "sed -n …" instead of "sed s/ …/p -e d" in s-header-vars
- From: Olivier Hainque <hainque at adacore dot com>
- To: Hans-Peter Nilsson <hp at bitrange dot com>
- Cc: Olivier Hainque <hainque at adacore dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 15 May 2012 16:15:24 +0200
- Subject: Re: Use "sed -n …" instead of "sed s/ …/p -e d" in s-header-vars
- References: <46CAFB9F-3DE7-46A8-931F-17D490926100@adacore.com> <alpine.BSF.2.00.1205142317040.28096@dair.pair.com>
Hello Hans,
On May 15, 2012, at 05:22 , Hans-Peter Nilsson wrote:
>
>> * Makefile.in (s-header-vars): Resort to -n instead of trailing
>> -e d in sed invocation.
>
> Random non-maintainer comments: I'd suggest adding a nearby
> comment to avoid a future edit changing it back.
Sure.
> The attachment with the patch had the mime-type "Video/X-DV", maybe
> indicating an issue with your mail-client setup mismatching the .dif
> filename suffix.
Ah, right. I have added a comment, regenerated the patch
with a .diff extension and will take the opportunity to "ping".
Thanks for your comments,
With Kind Regards,
Olivier