Re: [patch] Fix LTO regression in Ada

[Richard Guenther <richard dot guenther at gmail dot com>]

On Thu, May 10, 2012 at 12:12 PM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>> Hmm, but we will not possibly refer to the sizes therein, so emitting
>> stmts for them
>> looks pointless ... (and in fact the debug information would be odd,
>> too ... what
>> does dwarf2out.c do with these CALL_EXPRs when generating debug information
>> without LTO?)
>
> All variable-sized types currently get size -1, but this would change with:
> ?http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00422.html
>
>> Anyway, the idea is reasonable, but I'm not sure ending up with calls in
>> those sizes makes sense (don't we make sure to "inline" them all at some
>> point?)
>
> These types are like any other types in Ada. ?Either DECL_ORIGINAL_TYPE is
> purely for debug info and then we shouldn't stream it for LTO or it isn't and
> it needs to be gimplified. ?My personal inclination would be for the former,
> but this is apparently problematic for C++. ?I can add a ??? comment though.

Well, we need to stream it for LTO because at the moment LTO is still
responsible
for emitting debug information ... (that would change with the "early
debug info" plan).

Ok with a ??? comment.

Thanks,
Richard.

> --
> Eric Botcazou