Re: [C++ Patch] PR 53158

[Paolo Carlini <paolo dot carlini at oracle dot com>]

Hi again,

On 05/08/2012 03:00 PM, Jason Merrill wrote:
> On 05/07/2012 11:28 PM, Paolo Carlini wrote:
> > error: could not convert âb.main()::<lambda()>()â from âvoidâ to âboolâ
>
> It wouldn't say "operator()"?
>
> I think I'd leave that alone; it is somewhat more informative (about 
> what b() expands to) and we're moving toward replacing %qE with caret 
> anyway.
>
> The patch to ocp_convert is OK.
As you may have noticed, the patchlet is still unapplied (I'm attaching 
below what I have tested and ready to get in per your approval).

Is unapplied because I was really nervous due to the wrong location 
(thus caret) of the error call, at the end of the whole condition. Now, 
I'm wondering, shall we consistently use error_at (location_of (expr), 
... for the error messages produced by the *convert* functions? The 
below quick fix makes me *much* more happy, the caret points to the 
closed round brace of the b() call. Can I trust all the exprs to come 
with an embedded location *at least* as accurate as input_location, 
normally better? In case I can do a pass through all of cvt.c etc and 
repost a largish patch...

Thanks!

Paolo.

////////////////

Attachment: patch_53158_3
Description: Text document

Attachment: patchlet_proposal
Description: Text document