This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PR c++/24985 caret diagnostics for macro expansions

From: Gabriel Dos Reis <gdr at integrable-solutions dot net>
To: Manuel López-Ibáñez <lopezibanez at gmail dot com>
Cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>, Dodji Seketeli <dodji at redhat dot com>, Jason Merrill <jason at redhat dot com>
Date: Thu, 3 May 2012 19:08:59 -0500
Subject: Re: PR c++/24985 caret diagnostics for macro expansions
References: <CAESRpQBpOiwbKR1Yca1VuHNuc-5RQc71Op7pENtga0Cu2AtEZg@mail.gmail.com> <CAAiZkiAO4Gz_OuUdjAtoA-CxzJzYXP5DGEGvVz57ccCaM73vuw@mail.gmail.com> <CAESRpQBchY2YEG1FNR8RSOSB-LRuMGSkZ=OvD7d8eP_wq1f7hg@mail.gmail.com>

On Thu, May 3, 2012 at 6:56 PM, Manuel López-Ibáñez
<lopezibanez@gmail.com> wrote:
> On 4 May 2012 01:09, Gabriel Dos Reis <gdr@integrable-solutions.net> wrote:
>>
>> The patch changes indentation in several places (violating, I think
>> coding conventions) which are unrelated to the functionality
>> that the patch is supposed to implement. ?Could you resend
>> a version unencumbered by those changes for review?
>> The changes to use pp_get_prefix and pp_set_prefix are OK.
>
> Sure. Attached.
>
> Cheers,
>
> Manuel.

OK.

Follow-Ups:
- Re: PR c++/24985 caret diagnostics for macro expansions
  - From: Manuel López-Ibáñez

References:
- PR c++/24985 caret diagnostics for macro expansions
  - From: Manuel López-Ibáñez
- Re: PR c++/24985 caret diagnostics for macro expansions
  - From: Gabriel Dos Reis
- Re: PR c++/24985 caret diagnostics for macro expansions
  - From: Manuel López-Ibáñez

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]