This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR52571
- From: Mike Stump <mikestump at comcast dot net>
- To: Richard Guenther <rguenther at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 9 Apr 2012 16:54:07 -0700
- Subject: Re: [PATCH] Fix PR52571
- References: <alpine.LNX.2.00.1203141307380.27160@zhemvz.fhfr.qr> <alpine.LNX.2.00.1203141359120.27160@zhemvz.fhfr.qr>
On Mar 14, 2012, at 5:59 AM, Richard Guenther wrote:
>> This fixes PR52571, we should not align DECL_COMMON variables as
>> they might be pre-empted by a definition with lower alignment.
I added this to the PR:
Ah, I had another thought. COMDAT and LINKONCE things I don't think can be realigned for all the same reasons that one cannot align COMMON. I've not thought about this long and hard, so, could be wrong, so, would be good to have a C++ or a vectorizer person review the idea. The idea is, if you compile one translation unit with a vectorizor on, and another with it off, we wind up with two instantiations, each with different alignment, and the one picked at the end need not be either of them, but rather an explicit instantiation. This seems identical to what happens to common to me.