This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Define TRY_EMPTY_VM_SPACE for Linux/x32
On Wed, Apr 4, 2012 at 8:47 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Apr 4, 2012 at 11:08 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
>> Hello!
>>
>>> This patch defines TRY_EMPTY_VM_SPACE for Linux/x32. ?Tested on Linux/x32.
>>> OK for trunk?
>>>
>>> 2012-04-03 ?H.J. Lu ?<hongjiu.lu@intel.com>
>>>
>>> ? ? ? * config/host-linux.c (TRY_EMPTY_VM_SPACE): Defined to
>>> ? ? ? 0x60000000 for x32.
>>
>> I think we can simply check for __LP64__, without version check, as is
>> the case with SPARC and MIPS targets.
>
> When you compile GCC 4.8 with GCC 3.2 on Linux/x86-64,
> __LP64__ won't be defined and TRY_EMPTY_VM_SPACE
> will be 0x60000000 instead of 0x1000000000.
Looking at how other targets implement this check, I don't think that
this is a problem at all. This issue only shows on a non-bootstrapped
build. A full bootstrap will use correct address.
Uros.