This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Add --with-abi= support to x86_64-*-*
- From: "Nathanael Nerode (GCC)" <ncn_gcc10 at fastmail dot fm>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Uros Bizjak <ubizjak at gmail dot com>, DJ Delorie <dj at redhat dot com>, Alexandre Oliva <aoliva at redhat dot com>, Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>, gcc-patches at gcc dot gnu dot org
- Date: Mon, 02 Apr 2012 22:34:50 -0400
- Subject: Re: PATCH: Add --with-abi= support to x86_64-*-*
- References: <20120302180050.GA27835@intel.com> <CAMe9rOpv=mEN7AC=Kgf1oTU=j3X+Mxuun3LiALwx1t9zpEh70g@mail.gmail.com> <4F6F8DD1.8060201@fastmail.fm> <CAMe9rOrPmwZ7he06tSsTD0TnES_4f8W5WANzgiAjPbGWy-p_QQ@mail.gmail.com>
On 03/28/2012 09:06 PM, H.J. Lu wrote:
> On Sun, Mar 25, 2012 at 2:27 PM, Nathanael Nerode (GCC)
> <ncn_gcc10@fastmail.fm> wrote:
>>
>>> Hi,
>>>
>>> Can any build maintainers review this patch?
>>
>> I don't feel comfortable reviewing this, because I don't fully
>> comprehend the intricacy of the interactions in this area. It *looks*
>> good, but I don't trust my review abilities here. If this has been
>> tested *in each of the possible modes* on x86-64, then I would approve
>> it, but there are an awful lot of combinations, and "Tested on
>> Linux/x32" does not tell me whether it works correctly on all of them.
>>
>> Perhaps someone else will be more able to review this by reading through
>> the logic tree.
>>
>>>
>>> Thanks.
>>>
>>
>
> Since OPTION_MASK_ABI_64 and OPTION_MASK_ABI_X32 have
> been added, the --with-abi= patch is much simpler. It just includes
> i386/biarchx32.h instead of i386/biarch64.h when --with-abi={x32|mx32}
> or --with-multilib-list=mx32 is used. OK for trunk?
>
> Thanks.
>
>
Yes, OK for trunk.