This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Support for Runtime CPU type detection via builtins (issue5754058)
- From: Michael Matz <matz at suse dot de>
- To: Sriraman Tallam <tmsriram at google dot com>
- Cc: reply at codereview dot appspotmail dot com, gcc-patches at gcc dot gnu dot org
- Date: Fri, 30 Mar 2012 14:47:10 +0200 (CEST)
- Subject: Re: Support for Runtime CPU type detection via builtins (issue5754058)
- References: <20120330001021.9E30EB2086@azwildcat.mtv.corp.google.com>
Hi,
On Thu, 29 Mar 2012, Sriraman Tallam wrote:
> +struct __processor_model
> +{
> + /* Vendor. */
> + unsigned int __cpu_is_amd : 1;
> + unsigned int __cpu_is_intel : 1;
> + /* CPU type. */
> + unsigned int __cpu_is_intel_atom : 1;
> + unsigned int __cpu_is_intel_core2 : 1;
> + unsigned int __cpu_is_intel_corei7 : 1;
> + unsigned int __cpu_is_intel_corei7_nehalem : 1;
> + unsigned int __cpu_is_intel_corei7_westmere : 1;
> + unsigned int __cpu_is_intel_corei7_sandybridge : 1;
> + unsigned int __cpu_is_amdfam10h : 1;
> + unsigned int __cpu_is_amdfam10h_barcelona : 1;
> + unsigned int __cpu_is_amdfam10h_shanghai : 1;
> + unsigned int __cpu_is_amdfam10h_istanbul : 1;
> + unsigned int __cpu_is_amdfam15h_bdver1 : 1;
> + unsigned int __cpu_is_amdfam15h_bdver2 : 1;
> +} __cpu_model;
It doesn't make sense for the model to be a bitfield, a processor will
have only ever exactly one model. Just make it an enum or even just an
int.
Ciao,
Michael.