This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [SH] PR 50751 - rework displacement calculations
- From: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- To: oleg dot endo at t-online dot de
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 27 Mar 2012 19:14:26 +0900 (JST)
- Subject: Re: [SH] PR 50751 - rework displacement calculations
- References: <1332802773.1876.339.camel@yam-132-YW-E178-FTW>
Oleg Endo <oleg.endo@t-online.de> wrote:
> The attached patch generalizes the move insn displacement calculations a
> little bit. Before, the same address rebasing code was present in
> sh_legitimize_address as well as sh_legitimize_reload_address. I've
> pulled those out into a separate function as a preparation step for
> adding HImode displacement addressing support.
>
> Tested by doing 'make all' (c,c++), compiling newlib and by making sure
> that for the following variants the CSiBE set code size did not change:
>
> -m2a-single -mb -O2, -m2a-single -mb -Os,
> -m4a-single -mb -O2, -m4a-single -mb -Os,
> -m4a-single -ml -O2, -m4a-single -ml -Os,
> -m4-single -mb -O2, -m4-single -mb -Os,
> -m4-single -ml -O2, -m4-single -ml -Os
>
> I'm now also running the usual reg tests on sh-sim, just in case.
> Other than that, OK?
OK with removing the first hunk
> @@ -9663,10 +9663,12 @@
> {
> if (MAYBE_BASE_REGISTER_RTX_P (x, strict))
> return true;
> +
> else if ((GET_CODE (x) == POST_INC || GET_CODE (x) == PRE_DEC)
> && ! TARGET_SHMEDIA
> && MAYBE_BASE_REGISTER_RTX_P (XEXP (x, 0), strict))
> return true;
> +
> else if (GET_CODE (x) == PLUS
> && (mode != PSImode || reload_completed))
> {
which adds extra empty lines.
Regards,
kaz