This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[C++ Patch] PR 52487
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: Jason Merrill <jason at redhat dot com>
- Date: Tue, 20 Mar 2012 16:11:54 +0100
- Subject: [C++ Patch] PR 52487
Hi,
this regression is about literal_type_p ICEing for types which cannot be
completed. Indeed, for the testcase, complete_type cannot complete the
type but doesn't error out either, just returns the type as-is, and the
gcc_assert triggers. We could imagine handling such types in the caller
- check_field_decls - but in my opinion makes more sense to just allow
such types and return false. I also considered changing literal_type_p
to use complete_type_or_else but then it's easy to produce duplicate
diagnostics, for example. What do you think?
Tested x86_64-linux.
Thanks,
Paolo.
PS: eventually I guess we want to fix this in mainline and 4.7.1.
///////////////////////////
Attachment:
CL_52487
Description: Text document
Attachment:
patch_52487
Description: Text document