This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH,testsuite,committed] Skip some tests for

From: "William J. Schmidt" <wschmidt at linux dot vnet dot ibm dot com>
To: Rainer Orth <ro at cebitec dot uni-bielefeld dot de>
Cc: gcc-patches at gcc dot gnu dot org, bergner at vnet dot ibm dot com
Date: Mon, 12 Mar 2012 14:09:24 -0500
Subject: Re: [PATCH,testsuite,committed] Skip some tests for
References: <1331577011.2680.2.camel@gnopaine> <yddsjhdis4q.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <yddk42pirwl.fsf@manam.CeBiTec.Uni-Bielefeld.DE>

OK, will do.  I just copied the style of some other test cases that
skipped darwin, assuming that was the preferred syntax.

Thanks,
Bill

On Mon, 2012-03-12 at 19:40 +0100, Rainer Orth wrote:
> Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
> 
> >> +/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */
> >
> > Please omit defaults to dg-skip-if: { "*" } { "" } are unnecessary and
> > make the directive harder to read.
> 
> Oh, I forgot: please indicate why you are skipping the test in the
> comment field, like:
> 
> /* { dg-skip-if "PR tree-optimization/46728" { powerpc*-*-darwin* } } */
> 
> Thanks.
>         Rainer
>

Follow-Ups:
- Re: [PATCH,testsuite,committed] Skip some tests for
  - From: Rainer Orth

References:
- [PATCH,testsuite,committed] Skip some tests for powerpc*-*-darwin*
  - From: William J. Schmidt
- Re: [PATCH,testsuite,committed] Skip some tests for powerpc*-*-darwin*
  - From: Rainer Orth
- Re: [PATCH,testsuite,committed] Skip some tests for powerpc*-*-darwin*
  - From: Rainer Orth

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]