This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Check ptr_mode and use Pmode in ix86_trampoline_init

From: Uros Bizjak <ubizjak at gmail dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org, Richard Henderson <rth at redhat dot com>
Date: Sun, 11 Mar 2012 17:20:00 +0100
Subject: Re: PATCH: Check ptr_mode and use Pmode in ix86_trampoline_init
References: <20120311011847.GA11408@intel.com> <CAFULd4Zf-P75sn97P5G39qen==HEgnrzJAFpSAqe2r59hmGQmg@mail.gmail.com> <CAMe9rOoZxuJ6R7sigRO_GUUpQZmUcqK_=P7iBpLFNAw5rjF=OQ@mail.gmail.com>

On Sun, Mar 11, 2012 at 4:52 PM, H.J. Lu <hjl.tools@gmail.com> wrote:

>>> x86 trampoline depends on ptr_mode. ?This patch checks ptr_mode, instead
>>> of TARGET_X32. ?Also we should use Pmode for address mode. ?Tested on
>>> Linux/x86-64. ?OK for trunk?
>>
>> Why we are looking at ptr_mode here?
>>
>
> If ptr_mode is SImode, we can always use movl to reach our target.
> We don't need to check anything else.

Under this assumption, the patch is OK.

Thanks,
Uros.

References:
- PATCH: Check ptr_mode and use Pmode in ix86_trampoline_init
  - From: H.J. Lu
- Re: PATCH: Check ptr_mode and use Pmode in ix86_trampoline_init
  - From: Uros Bizjak
- Re: PATCH: Check ptr_mode and use Pmode in ix86_trampoline_init
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]