This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: libgo patch committed: Fill out syscall package for GNU/Linux
Ian Lance Taylor <iant@google.com> writes:
> Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
>
>> Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
>>
>>> Ian Lance Taylor <iant@google.com> writes:
>>>
>>>> This patch to libgo fills out the syscall package for GNU/Linux to match
>>>> all the functions in the syscall package in the master Go library.
>>>> There is a test case for this patch at
>>>> http://code.google.com/p/go/issues/detail?id=3071 . Bootstrapped and
>>>> ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline.
>>>
>>> Unfortunately, this broke Solaris bootstrap:
>>
>> It also broke Linux/x86_64 bootstrap (CentOS 5.6):
>>
>> In file included from /usr/include/sys/ustat.h:30:0,
>> from /usr/include/ustat.h:1,
>> from sysinfo.c:91:
>> /usr/include/bits/ustat.h:25:8: error: redefinition of 'struct ustat'
>> In file included from /usr/include/linux/filter.h:8:0,
>> from sysinfo.c:61:
>> /usr/include/linux/types.h:156:8: note: originally defined here
>
>
> After some actual testing, this additional patch seems to be needed to
> fix the problem. Bootstrapped and ran Go testsuite on
> x86_64-unknown-linux-gnu. Committed to mainline.
This patch and the preceding one need to go onto the 4.7 branch, too,
otherwise bootstrap on Solaris and CentOS 5.6 is broken.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University