This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: fix libstdc++/52433

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Jonathan Wakely <jwakely dot gcc at gmail dot com>
Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Thu, 08 Mar 2012 11:22:40 +0100
Subject: Re: fix libstdc++/52433
References: <CAH6eHdRXaBCebFd2kmsLGCKHLLXvVKvJ5kw5JZbPvjLWFEvR+Q@mail.gmail.com> <CAH6eHdTnm4w9BEF4krJF7fb3XtDeUg=66p_JWYhPn0OhTL0_Hw@mail.gmail.com>

On 03/08/2012 02:06 AM, Jonathan Wakely wrote:

On 4 March 2012 12:56, Jonathan Wakely wrote:

        PR libstdc++/52433
        * include/debug/safe_iterator.h (_Safe_iterator): Add move
        constructor and move assignment operator.
        * testsuite/23_containers/vector/debug/52433.cc: New.

Tested 'make check check-debug' on x86_64 and committed to trunk.  I
plan to fix this for 4.7.1 and 4.6.4 as well

This restores the debug mode checks when moving singular iterators.

Thanks for the good work on this.

By the way, this morning it occurred to me that we should probably also have debug-mode checks for self move-assignment (not just in _Safe_iterator)?!?

Or I'm missing something?

Thanks,
Paolo.

Follow-Ups:
- Re: fix libstdc++/52433
  - From: Jonathan Wakely

References:
- fix libstdc++/52433
  - From: Jonathan Wakely
- Re: fix libstdc++/52433
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]