This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, i386] RTM support

From: Kirill Yukhin <kirill dot yukhin at gmail dot com>
To: Uros Bizjak <ubizjak at gmail dot com>
Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>, Jakub Jelinek <jakub at redhat dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>, Andi Kleen <andi at firstfloor dot org>, Kirill Yukhin <kirill dot yukhin at gmail dot com>
Date: Mon, 5 Mar 2012 15:31:32 +0400
Subject: Re: [PATCH, i386] RTM support
Authentication-results: mr.google.com; spf=pass (google.com: domain of kirill.yukhin@gmail.com designates 10.180.107.99 as permitted sender) smtp.mail=kirill.yukhin@gmail.com; dkim=pass header.i=kirill.yukhin@gmail.com
References: <CAGs3RftzMrnzFuDGv2RHvboA9utwncOuphB_G6ELDAFw-N3DNA@mail.gmail.com> <CAFULd4ajpdZiAxWNdxwr3Y9=0ThyReVBrLo1v+Awqy_auihwpA@mail.gmail.com> <CAGs3RftVWLvDKrKaQDvFKc9Dtb5DpQkPr4=S5=qHf+-R1sLz5Q@mail.gmail.com>

Adding patch

On Mon, Mar 5, 2012 at 3:30 PM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> Hello Uros,
>
>> As the first remark, you don't have to add BLKmode memory clobbers.
>> unspec_volatile RTX is considered to use and clobber all memory:
>>
>
> Thanks, fixed!
>
>>
>> But, I think that we want to use code label from the top of the false
>> branch instead of ".+6". The question is, how to get it ...
>
> Agreed, this seems not as nice, but still it works :)
> I still do not understand, why not to put something like this?
> "xbegin\t1f\n1:"
> This is local label, which is not intercept others...
>
>>
>> Please use ix86_expand_setcc instead of opencoding sete insn.
>>
>
> Fixed!
>
> Anything else?
>
> Thanks, K

Attachment: rtm-2.gcc.patch
Description: Binary data

Follow-Ups:
- Re: [PATCH, i386] RTM support
  - From: Andi Kleen

References:
- Re: [PATCH, i386] RTM support
  - From: Kirill Yukhin

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]