Re: [patch, libffi] Sync merge libffi

[John David Anglin <dave at hiauly1 dot hia dot nrc dot ca>]

On Sun, 04 Mar 2012, Anthony Green wrote:

> Hello,
>
> The attached patch includes changes that have been reviewed, approved and 
> merged into the stand-alone libffi release tree**.
> Tested on x86_64 linux with no regressions, and committed.
>
> Thanks,
> Anthony Green

I'd like to question some of the changes in copyright.  For example,
the file src/pa/ffi.c was originally written by Randolph Chung.  The
copyright notice read as follows on the original contribution:

ffi.c - (c) 2003-2004 Randolph Chung <tausq@debian.org>
3 	
4 	HPPA Foreign Function Interface
5 	
6 	Permission is hereby granted, free of charge, to any person obtaining
7 	a copy of this software and associated documentation files (the
8 	``Software''), to deal in the Software without restriction, including
9 	without limitation the rights to use, copy, modify, merge, publish,
10 	distribute, sublicense, and/or sell copies of the Software, and to
11 	permit persons to whom the Software is furnished to do so, subject to
12 	the following conditions:
13 	
14 	The above copyright notice and this permission notice shall be included
15 	in all copies or substantial portions of the Software.
16 	
17 	THE SOFTWARE IS PROVIDED ``AS IS'', WITHOUT WARRANTY OF ANY KIND, EXPRESS
18 	OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
19 	MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
20 	IN NO EVENT SHALL CYGNUS SOLUTIONS BE LIABLE FOR ANY CLAIM, DAMAGES OR
21 	OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
22 	ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
23 	OTHER DEALINGS IN THE SOFTWARE.

It now reads as follows:

/* -----------------------------------------------------------------------
   ffi.c - (c) 2011 Anthony Green
	   (c) 2008 Red Hat, Inc.
	   (c) 2006 Free Software Foundation, Inc.
	   (c) 2003-2004 Randolph Chung <tausq@debian.org>
					       
  HPPA Foreign Function Interface
  HP-UX PA ABI support 

  Permission is hereby granted, free of charge, to any person obtaining
  a copy of this software and associated documentation files (the
  ``Software''), to deal in the Software without restriction, including
  without limitation the rights to use, copy, modify, merge, publish,
  distribute, sublicense, and/or sell copies of the Software, and to
  permit persons to whom the Software is furnished to do so, subject to
  the following conditions:

  The above copyright notice and this permission notice shall be included
  in all copies or substantial portions of the Software.

  THE SOFTWARE IS PROVIDED ``AS IS'', WITHOUT WARRANTY OF ANY KIND,
  EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
  MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
  NONINFRINGEMENT.  IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
  HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
  WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  DEALINGS IN THE SOFTWARE.
----------------------------------------------------------------------- */

I'm just wondering why Anthony Green and Redhat are listed as copyright holders.
I can understand the Free Software Foundation addition since the file was
contributed to it.

Dave
-- 
J. David Anglin                                  dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)