This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [google][4.6]Bug fix to function reordering plugin to check presence of elf.h
- From: Jing Yu <jingyu at google dot com>
- To: Sriraman Tallam <tmsriram at google dot com>
- Cc: Xinliang David Li <davidxl at google dot com>, Paul Pluzhnikov <ppluzhnikov at google dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 1 Mar 2012 13:31:22 -0800
- Subject: Re: [google][4.6]Bug fix to function reordering plugin to check presence of elf.h
- Authentication-results: mr.google.com; spf=pass (google.com: domain of jingyu@google.com designates 10.50.236.3 as permitted sender) smtp.mail=jingyu@google.com; dkim=pass header.i=jingyu@google.com
- References: <CAAs8HmzQBim4ea3fQ5TvXwTwcnQokLKLUo2yf8FR3xHqAD3fDw@mail.gmail.com> <CAAkRFZ+nbntK38PkoE5wVkKRwEcbHBg4Bbg--rLi3sMeLnE2Vw@mail.gmail.com> <CAAs8HmwmazxWioZOjRxFMejarAKh+qhC9-VW7mTCNt-QZgOqjw@mail.gmail.com>
I ported this patch into google/gcc-4_6_2-mobile.
Thanks,
Jing
On Sat, Feb 25, 2012 at 1:40 PM, Sriraman Tallam <tmsriram@google.com> wrote:
> Committed now, thanks.
>
> -Sri.
>
> On Fri, Feb 24, 2012 at 11:18 PM, Xinliang David Li <davidxl@google.com> wrote:
>> ok.
>>
>> David
>>
>> On Fri, Feb 24, 2012 at 4:19 PM, Sriraman Tallam <tmsriram@google.com> wrote:
>>> function_reordering_plugin.c includes <elf.h> which is not available
>>> on non-ELF platforms building a cross-compiler. This patch checks for
>>> <elf.h> before including it. Otherwise, it redefines the macros used.
>>> This is safe becaue the macros will not change.
>>>
>>> For context, this linker plugin itself is only available in the google
>>> 4_6 branch and I will port it to other branches and make it available
>>> for review for trunk soon.
>>>
>>>
>>> 2012-02-24 ?Sriraman Tallam ?<tmsriram@google.com>
>>>
>>> ? ? ? ?* function_reordering_plugin.c: Check for presence of elf.h.
>>> ? ? ? ?Otherwise, redefine the elf macros used.
>>>
>>> Ok to commit?
>>>
>>> Thanks,
>>> -Sri.