This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix ARM neon vashr<mode>3 and vlshr<mode>3 expanders (PR target/52375)


On 27/02/12 15:12, Jakub Jelinek wrote:
> Hi!
> 
> We ICE shortly after expansion on this testcase, because
> vlshrv4si3 expander is called with a SUBREG as operands[2],
> but we were testing just for REG_P, and in the other branch
> we assume that it is an immediate.  But there is no right shift
> with register shift count.
> 
> Fixed thusly, additionally moved the neg initialization down into
> the scope in which it is used to avoid creating a pseudo needlessly.
> Ok for trunk?
> 
> 2012-02-27  Jakub Jelinek  <jakub@redhat.com>
> 
> 	PR target/52375
> 	* config/arm/neon.md (vashr<mode>3, vlshr<mode>3): Use
> 	s_register_operand in the test instead of REG_P.  Don't call
> 	gen_reg_rtx if it won't be used.
> 
> 	* gcc.target/arm/pr52375.c: New test.
> 	* gcc.c-torture/compile/pr52375.c: New test.
> 

OK.

R.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]