This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, i386, Android] Enable __ANDROID__ macro for Android i386 target
- From: Ilya Enkovich <enkovich dot gnu at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, pavel dot v dot chupin at gmail dot com, Jing Yu <jingyu at google dot com>
- Date: Fri, 24 Feb 2012 13:51:44 +0400
- Subject: Re: [PATCH, i386, Android] Enable __ANDROID__ macro for Android i386 target
- Authentication-results: mr.google.com; spf=pass (google.com: domain of enkovich.gnu@gmail.com designates 10.68.243.197 as permitted sender) smtp.mail=enkovich.gnu@gmail.com; dkim=pass header.i=enkovich.gnu@gmail.com
- References: <CAMbmDYYu6vhyet+pK+-3CEwyYgJyZ6x4tMyVEU84CLyqth9=RQ@mail.gmail.com> <CAMe9rOo3ArbTy8bQaDhhHN=7ZrLxudUB6TcH5NOdfv-B_QSK3g@mail.gmail.com>
> On Wed, Feb 22, 2012 at 6:59 AM, Ilya Enkovich <enkovich.gnu@gmail.com> wrote:
>> Hello,
>>
>> Here is a one-line fix to enable __ANDROID__ macro on i386 Android
>> target. OK for trunk?
>>
>> Thanks,
>> Ilya
>> --
>>
>> 2012-02-22 ?Enkovich Ilya ?<ilya.enkovich@intel.com>
>>
>> ? ? ? ?* gcc/config/i386/gnu-user.h (TARGET_OS_CPP_BUILTINS): Add
>> ? ? ? ?ANDROID_TARGET_OS_CPP_BUILTINS.
>>
>>
>> diff --git a/gcc/config/i386/gnu-user.h b/gcc/config/i386/gnu-user.h
>> index 98d0a25..d317229 100644
>> --- a/gcc/config/i386/gnu-user.h
>> +++ b/gcc/config/i386/gnu-user.h
>> @@ -71,6 +71,7 @@ along with GCC; see the file COPYING3. ?If not see
>> ? do ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? \
>> ? ? { ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?\
>> ? ? ? ?GNU_USER_TARGET_OS_CPP_BUILTINS(); ? ? ?\
>> + ? ? ? ANDROID_TARGET_OS_CPP_BUILTINS(); ? ? ? \
>> ? ? } ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?\
>> ? while (0)
>
> I think this should be done in linux.h, not gnu-user.h.
I fix macro which is defined in gnu-user.h. How do you suppose me to
do it in linux.h?
Ilya
>
> --
> H.J.