This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH, PR 51782] Derive rtx address space from base object
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: Georg-Johann Lay <avr at gjlay dot de>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Martin Jambor <mjambor at suse dot cz>
- Date: Wed, 22 Feb 2012 10:20:25 +0100
- Subject: Re: [PATCH, PR 51782] Derive rtx address space from base object
- Authentication-results: mr.google.com; spf=pass (google.com: domain of firstname.lastname@example.org designates 10.50.15.231 as permitted sender) email@example.com; dkim=pass firstname.lastname@example.org
- References: <20120221125418.GA3849@virgil.arch.suse.de> <4F43CE24.email@example.com>
On Tue, Feb 21, 2012 at 6:02 PM, Georg-Johann Lay <firstname.lastname@example.org> wrote:
> Martin Jambor wrote:
>> PR 51782 showed that COMPONENT_REFs created by SRA got expanded with a
>> wrong address space because the address space was not specified in the
>> type of the whole tree. ?This is however inconsistent with how we
>> encode address spaces in MEM_REFs where they are supposed to be stored
>> in the type of its address operand (as opposed to the type of the
>> reference). ?Therefore the following patch changes the expansion to
>> always look at the base address and look through MEM_REFs if
>> It fixes the issue for me on a cross compiler, a bootstrap and
>> testsuite run on x86_64-linux showed only regressions described in PR
>> 52297 so I consider it successful. ?My understanding is that Richi
>> approved it in bugzilla. ?Georg-Johann Lay said he would test it on HW
>> or simulator that actually uses address spaces and he has also already
>> committed a testcase for this bug. ?Therefore I intend to commit the
>> patch if his tests pass too.
> The avr test suite has passed now, okay from that side.
And indeed the patch is ok from my side as well.