This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PR middle-end/52142: disallow inlining of certain TM_pure functions


On Tue, 2012-02-14 at 12:04 -0600, Aldy Hernandez wrote:
> Here we inline a transaction_pure function into a non transaction_pure 
> function, but end up instrumenting all the memory operations in the 
> tm_pure function regardless.
> 
> As discussed in the PR, we should've disallowed inlining of TM_pure 
> functions into non TM_pure functions.  We are currently only disabling a 
> subset of this, tm_safe callers.  The patch below disallows all inlining 
> of TM_pure functions into non TM_pure functions.
> 
> No regressions.
> 
> OK?  (I'm not sure whether the "looks good" was because I'm handsome, or 
> because it was an actual approval).

Will it inline transaction_pure into transaction_callable too?  That
would not be good if we actually instrument the transaction_callable.
Inlining transaction_pure into completely nontransactional code is fine
though.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]