This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Expand/update documentation on Epiphany interrupt attribute


On Tue, 7 Feb 2012, Joern Rennecke wrote:
> Tested by building 'info' for epiphany-elf, and by bootstrapping
> x86_64-unknown-linux-gnu .

Jörn, you are listed as epihphany maintainer, so you don't needs
to RFA patches like this.

That said...

Index: doc/extend.texi
===================================================================
+On Epiphany targets one or more optional parameters may added like this:
                                                       ^^^

...something doesn't seem right here.  Perhaps "can be added" or
"can be specified"?

+Permissible values for these parameters are: @w{@code{reset}},
+@w{@code{software_exception}}, @w{@code{page_miss}},
+@w{@code{timer0}}, @w{@code{timer1}}, @w{@code{message}},
+@w{@code{dma0}}, @w{@code{dma1}}, @w{@code{wand}} and @w{@code{swi}}.

Would everyone needing to use these know what these different options
refer to?

+Multiple parameters indicate that multiple entries in the interrupt
+vector table should be initialized for this function.  The
+parameter(s) may be omitted entirely, in which case no interrupt
+vector table entry will be provided.

Is "provided" the right term here?  I would have expected "set"
or "inserted" or something like that, but am not familiar with 
this setting, so feel free to ignore this.


The patch per se is fine.

Gerald

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]