This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Gthreads patch to disable static initializer macros

On 10 February 2012 14:48, Rainer Orth wrote:
> I've also noticed one feature of your patch that I don't like:
> __GTHREAD_{MUTEX,COND}_INIT_FUNCTION ignore the return values of
> pthread_{mutex,cond}_init_function instead of passing them on as all
> other gthr-posix.h functions do. ?This might lead to bad error handling,
> and my previous patch (based on an older version of yours you had
> attached to the PR) changed them to return int instead. ?I suppose
> changing this now is out of question, and this is left as 4.8 material.

I didn't like that feature of the patch much either, but the signature
of the mutex_init function is specified in gthr.h:

            some systems can't initialize a mutex without a
        function call.  On such systems, define this to a
        function which looks like this:
          void __GTHREAD_MUTEX_INIT_FUNCTION (__gthread_mutex_t *)

The recursive one says it should have the same signature, and I (maybe
wrongly) assumed the cond_init one should too.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]