This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch libjava]: Fix PR target/51500


2012/1/30 Andrew Haley <aph@redhat.com>:
> On 01/29/2012 02:15 PM, Kai Tietz wrote:
>> 2012-01-29 ?Kai Tietz ?<ktietz@redhat.com>
>>
>> ? ? ? PR target/51500
>> ? ? ? * interpret.cc (_Jv_init_cif): Handle thiscall
>> ? ? ? convention for 32-bit Windows.
>> ? ? ? * java/lang/reflect/natMethod.cc (_Jv_CallAnyMethodA):
>> ? ? ? Likewise.
>> ? ? ? * java/lang/reflect/natVMProxy.cc (ncode): Force SYSV
>> ? ? ? closure for 32-bit Windows.
>> ? ? ? (invoke_t): Add thiscall-attribute for 32-bit Windows.
>>
>> Patch tested for i686-w64-mingw32, i686-pc-cygwin, and
>> x86_64-unknown-linux-gnu. ?Ok for apply?
>
> Is it upstream? ?OK if so.
>
> Andrew.

Andrew,

I sent update-patch to ML for libffi to support closure-code for
thiscall.  So the hunk in patch for java/lang/reflect/natVMProxy.cc
(ncode): Force SYSV closure for 32-bit Windows. Isn't necessary, if
the fix in libffi gets applied.

Ok to commit patch without that hunk?  The standard-thiscall call
feature is already in libffi.

Regards,
Kai


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]