This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [libitm] Minor changes to libitm.h
- From: Torvald Riegel <triegel at redhat dot com>
- To: Patrick Marlier <patrick dot marlier at gmail dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Richard Henderson <rth at redhat dot com>, Aldy Hernandez <aldyh at redhat dot com>
- Date: Wed, 25 Jan 2012 01:32:49 +0100
- Subject: Re: [libitm] Minor changes to libitm.h
- References: <4F1F48E1.9000507@gmail.com>
On Tue, 2012-01-24 at 19:12 -0500, Patrick Marlier wrote:
> I propose some minor modifications to libitm.h:
> * Add a link to current TM-ABI document.
We should link to libitm.texi instead because this describes the
interface that we implement.
> * Remove ITM_REGPARM from _ITM_beginTransaction since on x86-32, a
> variadic function ignores regparm.
> * Add ITM_PURE to _ITM_addUserCommitAction and _ITM_addUserUndoAction to
> be usable inside transactions.
Those should be called from transaction_pure code only, or from wrapper
functions linked to using transaction_wrapper. Thus, they don't need to
be pure. Alternatively, why should they be?