[Ada] Clean ups in container API

[Arnaud Charlet <charlet at adacore dot com>]

Declare container parameter as aliased (in) for function Constant_Reference,
and as aliased inout for function Reference.

Move declaration of reference functions to match the specification of the
package as described in RM12.

Move implementation of reference functions to their proper place in
alphabetical order, per GNAT style conventions.

Declare Element component of node or array as aliased, and use Element'Access
instead of Element'Unrestricted_Access, when returning access value.

In the implementation of the reference operations, check that the cursor
parameter designates the same container as the container parameter.

In the key-based reference operations, check whether the result of the search
for the node fails (it returns null or 0), and if so raise Constraint_Error,
before attempting to refer to the node.

Tested on x86_64-pc-linux-gnu, committed on trunk

2012-01-10  Matthew Heaney  <heaney@adacore.com>

	* a-cdlili.adb, a-cdlili.ads, a-cihama.adb, a-cihama.ads, a-coinve.adb,
	a-coinve.ads, a-ciorse.adb, a-ciorse.ads, a-coorma.adb, a-coorma.ads,
	a-cborma.adb, a-cborma.ads, a-cidlli.adb, a-cidlli.ads, a-cimutr.adb,
	a-cimutr.ads, a-cihase.adb, a-cihase.ads, a-cohama.adb, a-cohama.ads,
	a-coorse.adb, a-coorse.ads, a-cbhama.adb, a-cbhama.ads, a-cborse.adb,
	a-cborse.ads, a-comutr.adb, a-comutr.ads, a-ciorma.adb, a-cobove.adb,
	a-ciorma.ads, a-cobove.ads, a-convec.adb, a-convec.ads, a-cohase.adb,
	a-cohase.ads, a-cbdlli.adb, a-cbdlli.ads, a-cbmutr.adb, a-cbmutr.ads,
	a-cbhase.adb, a-cbhase.ads (Reference, Constant_Reference): Declare
	container parameter as aliased in/in out.
	Code clean ups.

Attachment: difs
Description: Text document