This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] libstdc++: Make it possible to annotate the shared pointer operations in the std::thread implementation
- From: Paolo Carlini <pcarlini at gmail dot com>
- To: Bart Van Assche <bvanassche at acm dot org>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>
- Date: Fri, 23 Dec 2011 18:04:23 +0100
- Subject: Re: [PATCH] libstdc++: Make it possible to annotate the shared pointer operations in the std::thread implementation
- References: <33987586.92vJibue4B@linux>
Hi,
> As documented in the libstdc++ manual, the shared pointer operations in
> libstdc++ headers can be instrumented by defining the macros
> _GLIBCXX_SYNCHRONIZATION_HAPPENS_BEFORE()/AFTER() and libstdc++ has to be
> rebuilt in order to instrument the remaining shared pointer operations.
> However, rebuilding libstdc++ is inconvenient. So let's move the thread
> wrapper code from thread.cc into <thread>.
First, do you have already a Copyright assignment on file? It's a precondition for any non trivial contribution.
That said, please leave alone the baselines. Otherwise, Jon can comment on whether the reshuffling makes sense and would be safe from the Abi point of view.
Paolo